Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK]: Look into pyciemss-service and Rabbit MQ to sort out typing #1757

Closed
Tom-Szendrey opened this issue Aug 23, 2023 · 2 comments
Closed
Assignees
Labels
task Development task

Comments

@Tom-Szendrey
Copy link
Contributor

Tom-Szendrey commented Aug 23, 2023

When Pyciemss is writing to RabbitMQ it is only receiving it as a btye[]
This is different as to when we send it we can write it as an object. We can then read it back as a string deserialized into our object again

@Tom-Szendrey
Copy link
Contributor Author

You will need to update pyciemss-service. You will have some rabbit MQ library to read up on and there should likely be a flag for them to be writing as String rather than Byte[]

Once the pyciemss-service is updated you will need to update our hmi-server

https://github.com/DARPA-ASKEM/Terarium/blob/0b1249484ceb507fe9c196a136801c91c373736d/packages/services/hmi-server/src/main/java/software/uncharted/terarium/hmiserver/resources/dataservice/SimulationResource.java#L168

  1. This channel needs its type updated
    partialSimulationStream
  2. the stream function does too
  3. the try catch stuff in the stream function can be removed as all of that typing will happen as we are reading it in instead

@YohannParis YohannParis assigned Jami159 and unassigned Jami159 Aug 29, 2023
@Tom-Szendrey Tom-Szendrey linked a pull request Sep 15, 2023 that will close this issue
@Tom-Szendrey
Copy link
Contributor Author

Now that we are moving to Spring this seems irrelevant due to deserializing with ObjectMapper anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Development task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants