[Task]: Ts/1024 calibrate tool read from mq #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S/1024-calibrate-tool-read-from-mq
…S/1024-calibrate-tool-read-from-mq
…S/1024-calibrate-tool-read-from-mq
…com/DARPA-ASKEM/TERArium into TS/1024-calibrate-tool-read-from-mq
…S/1024-calibrate-tool-read-from-mq
…S/1024-calibrate-tool-read-from-mq
…com/DARPA-ASKEM/TERArium into TS/1024-calibrate-tool-read-from-mq
Tom-Szendrey
requested review from
dgauldie,
dvince2,
YohannParis and
mwdchang
as code owners
…S/1024-calibrate-tool-read-from-mq
mwdchang
reviewed
Aug 23, 2023
...ain/java/software/uncharted/terarium/hmiserver/resources/dataservice/SimulationResource.java
Show resolved
Hide resolved
mwdchang
reviewed
Aug 23, 2023
packages/client/hmi-client/src/components/workflow/tera-calibration-node-ciemss.vue
Show resolved
Hide resolved
|
Didn't test. Code looks fine! |
mwdchang
approved these changes
Aug 23, 2023
YohannParis
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created an issue #1757 to check into the whole byte[] thing going on in this PR due to the pyciemss-service's output to MQ
In the meantime this functionally works:
Next steps will be to add a quick helper .ts file on hmi-client so using this poler can be more repeatable
as well as adding the progress bar itself