Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Correct external publication endpoints #1980

Closed
dvince2 opened this issue Oct 10, 2023 · 0 comments · Fixed by #1982
Closed

[BUG]: Correct external publication endpoints #1980

dvince2 opened this issue Oct 10, 2023 · 0 comments · Fixed by #1982
Assignees
@dvince2
Labels
bug Something isn't working

Comments

@dvince2
Copy link
Collaborator

dvince2 commented Oct 10, 2023

Describe the bug
The external publication endpoints are too different from the other asset type endpoints. They're using a numeric id instead of a string among other changes. In the future this may align with the other asset types but for now this needs to be unique.
@dvince2 dvince2 added the bug Something isn't working label Oct 10, 2023
@dvince2 dvince2 self-assigned this Oct 10, 2023
dvince2 added a commit that referenced this issue Oct 10, 2023
@dvince2
fix(hmi-server): Correct external publication endpoints #1980
cd39fc7 
* Fixing typing on the back end for external publications
* Adding tests
* Cleaning up xdd test
@dvince2 dvince2 linked a pull request Oct 10, 2023 that will close this issue
fix(hmi-server): Correct external publication endpoints #1980 #1982
Merged
@dvince2 dvince2 mentioned this issue Oct 10, 2023
Merged
dvince2 added a commit that referenced this issue Oct 10, 2023
@dvince2
fix(hmi-server): Correct external publication endpoints #1980 (#1982)
77de7a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvince2 dvince2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hmi-server): Correct external publication endpoints #1980 DARPA-ASKEM/terarium
1 participant
@dvince2