You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that interface/interaction has stabilized somewhat we should perform a round of cleanups to make intentions clearer, and to help build out new features more easily.
Clean up model-configuration index
For model configurations edits, we have this notion of index, which is used to get and to update model-configuration objects. Ideally this should just be the model-configuration ids: Ids are more stable and makes more sense than a seemingly independent and reusable component needing some sense of an index-number from the calling parent. Ids are also a log safer should we go about removing/disabling configurations which would cause all the index numbers to shift around.
Clean up utilities
The domain-specific logic of building the parameter-matrix resides in the pivot.js utility, we should just move it out - as it isn't even a pivot table anymore, much less a generic utility function. Suggestion:
create a new petri-matrix-service or something like that under model-representation/petri
The text was updated successfully, but these errors were encountered:
Summary
Now that interface/interaction has stabilized somewhat we should perform a round of cleanups to make intentions clearer, and to help build out new features more easily.
Clean up model-configuration index
For model configurations edits, we have this notion of index, which is used to get and to update model-configuration objects. Ideally this should just be the model-configuration ids: Ids are more stable and makes more sense than a seemingly independent and reusable component needing some sense of an index-number from the calling parent. Ids are also a log safer should we go about removing/disabling configurations which would cause all the index numbers to shift around.
Clean up utilities
The domain-specific logic of building the parameter-matrix resides in the pivot.js utility, we should just move it out - as it isn't even a pivot table anymore, much less a generic utility function. Suggestion:
The text was updated successfully, but these errors were encountered: