Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK]: Matrix configuration cleanup pass #2046

Closed
mwdchang opened this issue Oct 17, 2023 · 0 comments · Fixed by #2075
Closed

[TASK]: Matrix configuration cleanup pass #2046

mwdchang opened this issue Oct 17, 2023 · 0 comments · Fixed by #2075
Assignees
Labels
task Development task

Comments

@mwdchang
Copy link
Member

Summary

Now that interface/interaction has stabilized somewhat we should perform a round of cleanups to make intentions clearer, and to help build out new features more easily.

Clean up model-configuration index

For model configurations edits, we have this notion of index, which is used to get and to update model-configuration objects. Ideally this should just be the model-configuration ids: Ids are more stable and makes more sense than a seemingly independent and reusable component needing some sense of an index-number from the calling parent. Ids are also a log safer should we go about removing/disabling configurations which would cause all the index numbers to shift around.

Clean up utilities

The domain-specific logic of building the parameter-matrix resides in the pivot.js utility, we should just move it out - as it isn't even a pivot table anymore, much less a generic utility function. Suggestion:

  • create a new petri-matrix-service or something like that under model-representation/petri
@mwdchang mwdchang added task Development task and removed task Development task labels Oct 17, 2023
@github-actions github-actions bot added the task Development task label Oct 17, 2023
@shawnyama shawnyama linked a pull request Oct 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Development task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants