Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: organize matrix config functions #2075

Merged
merged 5 commits into from
Oct 23, 2023
Merged

clean: organize matrix config functions #2075

merged 5 commits into from
Oct 23, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 20, 2023 •
edited
Loading

Description

  • Put parameter and transition matrix generation into its own file
  • Use id to update model config instead of using its index in the table

@shawnyama shawnyama changed the title clean: organize matrix config functions and rm index requirement for updating config clean: organize matrix config functions Oct 20, 2023
@shawnyama shawnyama linked an issue Oct 20, 2023 that may be closed by this pull request
[TASK]: Matrix configuration cleanup pass #2046
Closed
@shawnyama shawnyama marked this pull request as ready for review October 20, 2023 20:23
mwdchang
mwdchang approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the clean up - this will make things easier to evolve going forward.

@shawnyama shawnyama merged commit 45e3ec9 into main Oct 23, 2023
5 checks passed
@shawnyama shawnyama deleted the clean-matrix-config branch October 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Matrix configuration cleanup pass
2 participants
@shawnyama @mwdchang