Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK]: clean up the --gap variables #3670

Closed
2 of 3 tasks
YohannParis opened this issue May 21, 2024 · 0 comments · Fixed by #3892
Closed
2 of 3 tasks

[TASK]: clean up the --gap variables #3670

YohannParis opened this issue May 21, 2024 · 0 comments · Fixed by #3892
Assignees
Labels
Front End/HMI Refactor Improvements to the codebase task Development task

Comments

@YohannParis
Copy link
Member

YohannParis commented May 21, 2024

Describe the task
We have an incomplete list of gap, margin, and padding variables and not all applied.
Their is a lack of consistency in the CSS and it's a mess.

Task Items

  • Find all the potential values used in the application .25rem, .5rem, .75rem, etc
  • Check if Tailwind already offers those values
  • Update the CSS variables to a up to date list of gaps, from XXS to XXL maybe

Goal
This needs to be done in a one swoop and the merge commit id should be added to the ignore list.
https://github.com/DARPA-ASKEM/terarium/blob/main/.github/CONTRIBUTING.md#ignore-commits-in-the-blame-view

@YohannParis YohannParis added task Development task Front End/HMI Refactor Improvements to the codebase labels May 21, 2024
@asylves1 asylves1 linked a pull request Jun 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End/HMI Refactor Improvements to the codebase task Development task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants