Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gap css styles #3892

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Refactor gap css styles #3892

merged 9 commits into from
Jun 21, 2024

Conversation

asylves1
Copy link
Contributor

Description

Added default values that match tailwind gaps to _variables.scss.
replaced some of the values for .25rem, .5rem & .75rem

Resolves #(issue)

@asylves1 asylves1 linked an issue Jun 17, 2024 that may be closed by this pull request
[TASK]: clean up the --gap variables #3670
Closed
3 tasks
@asylves1 asylves1 marked this pull request as ready for review June 17, 2024 15:13
@asylves1 asylves1 changed the title Some style gap changes for Some style gap changes Jun 17, 2024
@mwdchang mwdchang changed the title Some style gap changes Refactor gap css styles Jun 17, 2024
@mwdchang mwdchang requested review from shawnyama and removed request for mwdchang June 17, 2024 15:55
YohannParis
YohannParis reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the extra space in front of all var(--gap-1)

packages/client/hmi-client/src/assets/css/theme/_variables.scss Outdated Show resolved Hide resolved
packages/client/hmi-client/src/assets/css/theme/_variables.scss Outdated Show resolved Hide resolved
packages/client/hmi-client/src/assets/css/theme/designer/components/input/_autocomplete.scss Outdated Show resolved Hide resolved
packages/client/hmi-client/src/assets/css/theme/extensions/_autocomplete.scss Outdated Show resolved Hide resolved
YohannParis
YohannParis requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to check ALL the var(--gap-1) because they ALL have a space in front of them.

@asylves1 asylves1 merged commit 0e74894 into main Jun 21, 2024
5 checks passed
@asylves1 asylves1 deleted the 3670-task-clean-up-the-gap-variables branch June 21, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@YohannParis YohannParis YohannParis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: clean up the --gap variables
3 participants
@asylves1 @YohannParis @shawnyama