Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Group Mira Requests #4588

Closed
mwdchang opened this issue Aug 27, 2024 · 1 comment · Fixed by #4640
Closed

[BUG]: Group Mira Requests #4588

mwdchang opened this issue Aug 27, 2024 · 1 comment · Fixed by #4640
Assignees
Labels
bug Something isn't working

Comments

@mwdchang
Copy link
Member

mwdchang commented Aug 27, 2024

Summary

We are observing quite a decent amount of MIRA fetching concept errors, for example

https://app.staging.terarium.ai/projects/34e7b955-f408-4e8b-be27-9429480ad6aa/model/7508b278-caea-4d35-bb17-097bdd463f07

Which makes a bunch of MIRA queries

http://localhost:8080/api/mira/currie/ido:0000514?project-id=34e7b955-f408-4e8b-be27-9429480ad6aa

This is particularly egregious for stratified models, where many states share the same concepts, and we are sending and failing the same requests dozens of times. Resulting in traffic jam and dozens of error toasters.

image

Stack trace server side

2024-08-27 00:15:55 [ERROR] An unknown error occurred while MIRA was trying to determine concepts based on curies: ido:0000511 [software.uncharted.terarium.hmiserver.controller.mira.MiraController:394]
2024-08-27 00:15:55 [ERROR] An unknown error occurred while MIRA was trying to determine concepts based on curies: ido:0000514 [software.uncharted.terarium.hmiserver.controller.mira.MiraController:394]
2024-08-27 00:15:55 [ERROR] Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed: java.lang.IllegalArgumentException: HttpStatusCode is required] with root cause [org.apache.catalina.core.ContainerBase.[Tomcat].[localhost].[/].[dispatcherServlet]:175]
java.lang.IllegalArgumentException: HttpStatusCode is required
	at org.springframework.util.Assert.notNull(Assert.java:204)
	at org.springframework.http.ProblemDetail.forStatus(ProblemDetail.java:281)
	at org.springframework.web.server.ResponseStatusException.<init>(ResponseStatusException.java:94)
	at org.springframework.web.server.ResponseStatusException.<init>(ResponseStatusException.java:79)
	at org.springframework.web.server.ResponseStatusException.<init>(ResponseStatusException.java:56)
	at software.uncharted.terarium.hmiserver.controller.mira.MiraController.handleMiraFeignException(MiraController.java:402)

Task

  • Investigate why we are erroring out, perhaps we didn't set up the environment up properly or maybe the external MIRA service is no longer running
  • Consider caching the request so we don't kill the server. See simulation-service which use a promise based FIFO-cache
  • Consider batching the requests and consolidate into a single error message instead of several dozens of error messages
@mwdchang mwdchang added the bug Something isn't working label Aug 27, 2024
@Tom-Szendrey
Copy link
Contributor

also check why we are not getting mira is unavailable error message

@Tom-Szendrey Tom-Szendrey changed the title [BUG]: MIRA getting concepts erroring out [BUG]: Group Mira Requests Aug 29, 2024
@Tom-Szendrey Tom-Szendrey linked a pull request Aug 30, 2024 that will close this issue
@github-staff github-staff deleted a comment from mayank785 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants