Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache curries to not repeat calls for concepts #4640

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

Description

cache curries to not repeat calls for concepts

@Tom-Szendrey Tom-Szendrey linked an issue Aug 30, 2024 that may be closed by this pull request
@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review August 30, 2024 20:37
@Tom-Szendrey Tom-Szendrey requested review from dgauldie and YohannParis and removed request for YohannParis, asylves1, jryu01, shawnyama and blanchco August 30, 2024 20:37
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache parts look fine, but the error handling will probably need to be rethought.

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefere to cache the response.data than the promise myself.

@Tom-Szendrey Tom-Szendrey merged commit fcf0d10 into main Sep 3, 2024
5 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/4588-group-mira-requests branch September 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Group Mira Requests
3 participants