Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Model page shows incorrect/missing metadata when models has parameters named *_* #4764

Closed
liunelson opened this issue Sep 12, 2024 · 1 comment · Fixed by #4930
Closed
Assignees
Labels
bug Something isn't working

Comments

@liunelson
Copy link
Member

Describe the bug

I have a model (see below) for which the model page is showing incorrect parameter information.

  1. the parameter NPI_mult is shown as NPI only and is missing all its metadata
  2. ditto for the parameter vacc_mult
  3. all parameters r_* are forced into a single matrix, even though this model is not a product of stratification

This is probably due to the (incorrect) assumptions about IDs with *_*.

The model:
SEIRHD vacc model for LA County t0 = 10_28_2021 (1).json

To Reproduce
Steps to reproduce the behavior:

  1. Upload this model
  2. Inspect its model page
  3. Create a Configure Model operator and plug the model to it
  4. Inspect the parameter table to see the lack of values of NPI_mult, vacc_mult and the incorrect matrix for r_*

Screenshots
Screenshot 2024-09-11 at 9 55 07 PM
Screenshot 2024-09-11 at 9 54 57 PM
Screenshot 2024-09-11 at 9 54 47 PM
Screenshot 2024-09-11 at 9 37 08 PM

@liunelson liunelson added the bug Something isn't working label Sep 12, 2024
@mwdchang mwdchang self-assigned this Sep 12, 2024
@mwdchang
Copy link
Member

I think we can add additional heuristics to detect cases like this - but at some point these become educated guesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants