improve parsing for stratified parameters #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
requested review from
YohannParis,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
YohannParis
approved these changes
Sep 26, 2024
packages/client/hmi-client/src/model-representation/mira/mira.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Yohann Paris <github@yohannparis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve parser to reduce the number of false positives where we incorrectly identify something as stratified but it is not. Use the context (grounding info) data, if applicable to determine whether a parameter is the result of an earlier stratification process.
Testing
Load and view the attached AMR model
SEIRHD.vacc.model.for.LA.County.t0.10_28_2021.1.json
parameters like
NPI_multandvacc_multwill denoted as stand-alone parameters and not grouped under a stratified category. Ditto for ther_*variables.Closes: #4764