Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Intervention charts look like crap #5487

Closed
jamiewaese-uncharted opened this issue Nov 13, 2024 · 0 comments · Fixed by #5603
Closed

[BUG]: Intervention charts look like crap #5487

jamiewaese-uncharted opened this issue Nov 13, 2024 · 0 comments · Fixed by #5603
Assignees
Labels
bug Something isn't working Enhancement Improvements to features already in the application Front End/HMI

Comments

@jamiewaese-uncharted
Copy link
Contributor

jamiewaese-uncharted commented Nov 13, 2024

Our intervention charts look kinda bad, both on the workflow node and in the drilldown.

The problem is that the label start point is determined by the data value. For interventions that begin near the bottom of the chart, or interventions that have long names, this causes the label to spill out of the chart. Like this:

Image

While we can't solve all the issues, we can make it a lot better with two modifications:

  1. Make the label begin at the top of the chart. This may require putting an expression on the xOffset or yOffset property where you subtract the value of dy

and

  1. Add a "limit" to the label text that is roughly equivalent to the height of the chart.

Sort of like this:
Image
Image

This page may be useful: vegalite - labels page

@jamiewaese-uncharted jamiewaese-uncharted added bug Something isn't working Front End/HMI Enhancement Improvements to features already in the application labels Nov 13, 2024
@mloppie mloppie linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Enhancement Improvements to features already in the application Front End/HMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants