Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grounding extra concept to be updated #6436

Closed
YohannParis opened this issue Feb 5, 2025 · 0 comments · May be fixed by #6443
Closed

Grounding extra concept to be updated #6436

YohannParis opened this issue Feb 5, 2025 · 0 comments · May be fixed by #6443
Assignees
@YohannParis

Comments

@YohannParis
Copy link
Member

We need to remove the context property and only use the modifiers in Grounding.java.
https://github.com/DARPA-ASKEM/terarium/blob/main/packages/server/src/main/java/software/uncharted/terarium/hmiserver/models/dataservice/Grounding.java#L36-L46

We do not need to care about the loss of data in the DB because Jackson will not parse it.
dvince2 added a commit that referenced this issue Feb 5, 2025
@dvince2
[TASK]: Grounding extra concept to be updated #6436
fa20222 
Using the `modifiers` instead of `context`
@dvince2 dvince2 mentioned this issue Feb 5, 2025
Open
@dvince2 dvince2 linked a pull request Feb 5, 2025 that will close this issue
[TASK]: Grounding extra concept to be updated #6436 #6443
Open
dvince2 added a commit that referenced this issue Feb 5, 2025
@dvince2
[TASK]: Grounding extra concept to be updated #6436
6a5d7c3 
Using the `modifiers` instead of `context`
@dgauldie dgauldie assigned YohannParis and unassigned dvince2 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YohannParis YohannParis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK]: Grounding extra concept to be updated #6436 DARPA-ASKEM/terarium
2 participants
@YohannParis @dvince2