Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: canvas props config #1031

Merged
merged 14 commits into from
Apr 27, 2023
Merged

feat: canvas props config #1031

merged 14 commits into from
Apr 27, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 26, 2023 •
edited
Loading

Description

Head to http://localhost:8078/app/#/simulation-workflow to test this. In the video I am testing it in the project view just to show that it resizes by div and not just the window.

  • debugMode and scaleExtent are now props
  • grid lines are grey
  • jump to last position on canvas works (prop)
  • basic event emitter that pretends to save the last position onUnmount
Screen.Recording.2023-04-26.at.4.53.05.PM.mov

@shawnyama shawnyama marked this pull request as ready for review April 26, 2023 20:54
@mwdchang mwdchang merged commit 056e459 into main Apr 27, 2023
@mwdchang mwdchang deleted the canvas-config branch April 27, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnyama @mwdchang