feat: 1023 feat calibration page v0 #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…023-feat-calibration-page-v0
…023-feat-calibration-page-v0
Adding node.viewState
Tom-Szendrey
requested review from
dvince2,
YohannParis and
mwdchang
as code owners
|
@mwdchang can you please review and let me know if im on the right track here. Of course this is super ugly and also hard coded. |
dvince2
reviewed
Apr 28, 2023
packages/client/hmi-client/src/components/workflow/tera-calibration-node.vue
Show resolved
Hide resolved
Tom-Szendrey
commented
Apr 28, 2023
dvince2
reviewed
Apr 28, 2023
packages/client/hmi-client/src/types/workflow/calibrationOperation_Renaming.ts
Outdated
Show resolved
Hide resolved
mwdchang
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Hard coded inputs.
-Super super ugly at the moment I am aware
Screen.Recording.2023-04-28.at.3.38.01.PM.mov
Resolves #(issue)