feat: add simple pdf extraction service #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 30, 2023 19:37
tangopapatime
requested review from
dgauldie,
dvince2,
YohannParis and
mwdchang
as code owners
|
I haven't yet resolved the multipart pass through issue but have found a workaround for now. Need to add additional documentation as well. |
tangopapatime
changed the title
dvince2
reviewed
May 4, 2023
|
The major outstanding follow up task is to integrate this service as part of the orchestration. Especially if actually want this to work on |
dvince2
approved these changes
May 4, 2023
...are/uncharted/terarium/hmiserver/proxies/pdfextractionservice/PDFExtractionServiceProxy.java
Outdated
Show resolved
Hide resolved
...i-server/src/main/java/software/uncharted/terarium/hmiserver/resources/DownloadResource.java
Outdated
Show resolved
Hide resolved
...i-server/src/main/java/software/uncharted/terarium/hmiserver/resources/DownloadResource.java
Show resolved
Hide resolved
2 tasks
added 2 commits
May 5, 2023 10:44
tangopapatime
requested review from
YohannParis
and removed request for
YohannParis
|
I still need an check @YohannParis . Take a peak at this and see if it's a-ok. |
YohannParis
approved these changes
May 9, 2023
After a careful review of those 1000+ lines of code, I approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
Added a local pdf extraction service in Python/Flask
Added tera-drag-n-drop component to the project - v0 of setting up for user uploading.
Resolves #(issue)
Issue 1020
import_resource.webm