Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: a round of design-tweaks, add edge arrow marker #1076

Merged
merged 2 commits into from
May 8, 2023
Merged

chore: a round of design-tweaks, add edge arrow marker #1076

merged 2 commits into from
May 8, 2023

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented May 5, 2023

Summary

A around of tweaks:

  • Adding edge arrow marker, make edges more distinct
  • Make tera-workflow-node a bit closer to the design spec

image

Testing

No functional changes, workflow canvas should work as before.

@mwdchang mwdchang marked this pull request as ready for review May 8, 2023 13:21
@mwdchang mwdchang requested a review from YohannParis as a code owner May 8, 2023 13:21
@mwdchang mwdchang requested review from echl, Tom-Szendrey and shawnyama and removed request for YohannParis May 8, 2023 13:22
echl
echl approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@echl echl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think arrows might be a bit redundant since we should know the direction of the data flow implicitly since they always go from input to output?

@mwdchang
Copy link
Member Author

mwdchang commented May 8, 2023

I think arrows might be a bit redundant since we should know the direction of the data flow implicitly since they always go from input to output?

The arrows/edges go from output-to-input 😄

Arrows help in situation like this where your node are not necessarily ordered left-to-right
image

@mwdchang mwdchang merged commit 24a7651 into main May 8, 2023
@mwdchang mwdchang deleted the workflow-ui-refinement branch May 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echl echl echl approved these changes

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwdchang @echl