chore: 1066 task calibration updates #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
requested review from
dvince2,
YohannParis and
mwdchang
as code owners
…066-task-calibration-updates
Tom-Szendrey
changed the title
Tom-Szendrey
changed the title
YohannParis
reviewed
May 11, 2023
packages/services/hmi-server/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
YohannParis
approved these changes
May 12, 2023
dvince2
reviewed
May 12, 2023
dvince2
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calibration.Node.Run.mov
Letting the user set up their own calibration.
Note not all calibrations will converge. I also need to understand the implicit rules such as do initial params always need to sum to 1? This just means at the moment the user can easily make a calibration that returns null values
To Test:
I am running simulation service locally (It needs the following flag set to false to not send IDs)
ENABLE_TDS=falseThen create a calibration node and connect it to a model config and a dataset
align the timestamp column with a drop down as well as pair up the model nodes with their column names
click run
click get status (like already finished)
click get result