Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamie hide unnecessary run buttons in workflow #1580

Merged
merged 16 commits into from
Aug 1, 2023

Conversation

jamiewaese-uncharted
Copy link
Contributor

Just cleaning up the workflow nodes a bit. For instance:

  • hide run buttons that are disabled
  • make help message type settings consistent

BEFORE
hide disabled run buttons

AFTER
hide disabled run buttons - fixed

help message type settings

Here are all the nodes hooked up properly. The 'Run' buttons appear as they should.
Monosnap Terarium 2023-07-25 11-34-29

@mwdchang mwdchang requested review from Tom-Szendrey and removed request for YohannParis July 25, 2023 19:54
@Tom-Szendrey
Copy link
Contributor

I have changed from using modelColumnNames in these v-ifs to using modelConfigId and datasetId
If we are having logic to check if we have inputs on the nodes then we should use the values directly computed from the node's inputs rather than the column names that are derived later

…amie-hide-unnecessary-run-buttons-in-workflow
@Tom-Szendrey Tom-Szendrey merged commit f82b328 into main Aug 1, 2023
@Tom-Szendrey Tom-Szendrey deleted the jamie-hide-unnecessary-run-buttons-in-workflow branch August 1, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants