task: add resource filtering and new asset buttons #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
reviewed
Jul 25, 2023
YohannParis
reviewed
Jul 26, 2023
packages/client/hmi-client/src/page/project/components/tera-model-modal.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/page/project/components/tera-model-modal.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/page/project/components/tera-resource-sidebar.vue
Show resolved
Hide resolved
YohannParis
approved these changes
Jul 26, 2023
packages/client/hmi-client/src/model-representation/petrinet/petrinet-service.ts
Outdated
Show resolved
Hide resolved
…ttps://github.com/DARPA-ASKEM/Terarium into task-add-resource-filtering-and-new-asset-buttons
Jami159
pushed a commit
that referenced
this pull request
Jul 29, 2023
Co-authored-by: Cole Blanchard <cblanchard@Coles-MacBook-Pro.local> Co-authored-by: Yohann Paris <github@yohannparis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**I've moved the new model and workflow up to the
tera-project.vuecomponent and there was no changes to the functionality. Since the functionality to open a new model and workflow is the same between the side panel and the project overview page there needed to be an easier way to call the new asset functions from each component. The event to open a new asset it now bubbled up from thetera-project-overview-pageandtera-resource-sidebarwhere it is then handled in the sharedtera-projectcomponentFiltering:
Screen.Recording.2023-07-25.at.12.35.33.PM.mov
Side panel and overview new asset buttons:
Screen.Recording.2023-07-25.at.12.33.26.PM.mov
Resolves #1566