Jamie dataset preview toggle histograms #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiewaese-uncharted
requested review from
YohannParis and
mwdchang
as code owners
mwdchang
reviewed
Jul 25, 2023
packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue
Outdated
Show resolved
Hide resolved
YohannParis
approved these changes
Jul 26, 2023
packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a summary row above the datatable with a toggle switch to turn on/off the column summaries. This was part of the initial design.
DESIGN
AS IMPLEMENTED
TO DO
I'd love to fix that brief flash where the datatable gets drawn at full width for a frame, but that is a separate issue. This brief flash can also be seen on page load, and is unrelated to this new feature.