Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drilldown tab not showing #1648

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: drilldown tab not showing #1648

merged 1 commit into from
Jul 31, 2023

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Jul 31, 2023

Summary

The previous assetName/tab changes accidentally removed the single-tab mechanism we currently have in the drilldown panel. This restores this functionality.

Note the drilldown is acting a bit strange, when opening with different zoom levels on the workflow canvas the tab can be rendered incorrectly. Not exactly sure why.

Testing

Goto workflow

  • select a node and open drilldown
  • should be able to close drilldown

@mwdchang mwdchang requested a review from YohannParis as a code owner July 31, 2023 21:50
@mwdchang mwdchang requested a review from shawnyama July 31, 2023 21:51
@mwdchang mwdchang merged commit 4f9416e into main Jul 31, 2023
@YohannParis YohannParis deleted the fix-drilldown-tab branch August 8, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants