Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve stratify drilldown state when navigating forward/backward #1651

Merged
merged 19 commits into from
Aug 2, 2023

Conversation

echl
Copy link
Contributor

@echl echl commented Aug 1, 2023

Description

  • Preserve the state of each step of the stratify drilldown when you navigate forward or backward within the drilldown view.
  • Make generated strata ids same as names
  • Add type legend and collapsed view toggle button to tera-model-diagram

@echl echl marked this pull request as ready for review August 1, 2023 13:57
@echl echl marked this pull request as draft August 1, 2023 14:04
@echl echl marked this pull request as ready for review August 1, 2023 14:09
@mwdchang
Copy link
Member

mwdchang commented Aug 1, 2023

@echl can you briefly comment on what to look for, and how/where this notion of state is kept? The PR is pretty large and it is hard to follow.

@mwdchang mwdchang requested a review from Tom-Szendrey August 1, 2023 15:19
@mwdchang mwdchang merged commit d35a165 into main Aug 2, 2023
@mwdchang mwdchang deleted the stratify-fixes branch August 2, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants