Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/move to quarkus 3 #1682

Merged
merged 16 commits into from
Aug 10, 2023
Merged

Spike/move to quarkus 3 #1682

merged 16 commits into from
Aug 10, 2023

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Aug 10, 2023

This change moves us to quarkus 3. It is largely a straightforward update that will require devs only to install the latest quarkus on their machine (if they don't have it already).

THIS DOES NOT MOVE US TO REACTIVE

  • The move to quarkus reactive resulted in a lot of errors which need to be resolved first.
  • I want to move us to 3.X to iron out any unknown issues with that migration before updating us to quarkus reactive.

Of note in this PR:

  • Moving from Quarkus 2.16.6.Final to Quarkus 3.2.3.Final
  • As part of the dependency changes required for that, moving from javax.* to jakarta.*
  • Previously we had a double colon in our application.properties file. This is unallowed and is a reserved character combination for a secrets handler. There will be a corresponding orchestration fix for this.
  • Fixing deprecation warning in Converter.java

Note: This PR requires DARPA-ASKEM/orchestration#258 to also be ✅ for running from orchestration to work.

@dvince2 dvince2 requested a review from dgauldie as a code owner August 10, 2023 13:08
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine

@dvince2 dvince2 merged commit 869f957 into main Aug 10, 2023
@dvince2 dvince2 deleted the spike/move_to_quarkus_3 branch August 10, 2023 18:04
chris-dickson added a commit that referenced this pull request Aug 10, 2023
YohannParis pushed a commit that referenced this pull request Aug 11, 2023
Co-authored-by: David Gauldie <dgauldie@uncharted.software>
dvince2 added a commit that referenced this pull request Aug 14, 2023
(cherry picked from commit 869f957)
shawnyama pushed a commit that referenced this pull request Aug 14, 2023
shawnyama pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: David Gauldie <dgauldie@uncharted.software>
shawnyama pushed a commit that referenced this pull request Aug 14, 2023
shawnyama pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: David Gauldie <dgauldie@uncharted.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants