Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refresh model node #1709

Merged
merged 10 commits into from
Aug 15, 2023
Merged

fix: refresh model node #1709

merged 10 commits into from
Aug 15, 2023

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Aug 14, 2023 •
edited
Loading

Summary

Keep model-nodes updated with respect to the configurations

  • When workflow is mounted we will refresh the model-nodes, additional configurations will appear
  • When adding configurations in the drill-down we will also update the model-node(s).

Test

In workflow

  • Add a model node
  • Go into the drilldown, and create a new configuration
  • Note the configuration will be available in the workflow node's output port

@mwdchang mwdchang changed the title Refresh model node fix: refresh model node Aug 14, 2023
@mwdchang mwdchang marked this pull request as ready for review August 15, 2023 13:15
@mwdchang mwdchang requested a review from YohannParis as a code owner August 15, 2023 13:15
@mwdchang mwdchang merged commit 5ffa21e into main Aug 15, 2023
@mwdchang mwdchang deleted the refresh-model-node branch August 15, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis left review comments

@shawnyama shawnyama shawnyama approved these changes

Assignees

@shawnyama shawnyama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwdchang @YohannParis @shawnyama