Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enter on form modal submit #1730

Merged
merged 4 commits into from
Aug 18, 2023
Merged

fix: enter on form modal submit #1730

merged 4 commits into from
Aug 18, 2023

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Aug 17, 2023 •
edited
Loading

Description

  • fix an issue for adding a project/asset where the modal would close and not submit the form
  • modal will now emit an event when enter is press
  • modals themselves can define the action they want to do when enter is pressed
  • I've added enter action to modals where it makes sense
Screen.Recording.2023-08-17.at.1.18.31.PM.mov
Screen.Recording.2023-08-17.at.1.19.35.PM.mov

Resolves #(issue)
#1719

@blanchco blanchco self-assigned this Aug 17, 2023
@blanchco blanchco linked an issue Aug 17, 2023 that may be closed by this pull request
Click "enter" on create new project/assets should submit the form and not close the modal #1719
Closed
@blanchco blanchco marked this pull request as ready for review August 18, 2023 17:02
@mwdchang mwdchang merged commit 2909d34 into main Aug 18, 2023
@mwdchang mwdchang deleted the fix-enter-on-form-modal-submit branch August 18, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click "enter" on create new project/assets should submit the form and not close the modal
3 participants
@blanchco @YohannParis @mwdchang