Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default config also updates model #1736

Merged
merged 2 commits into from
Aug 21, 2023
Merged

update default config also updates model #1736

merged 2 commits into from
Aug 21, 2023

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Aug 18, 2023

Summary

This PR does two things

  • Allows default configuration to be changed
  • When changing default config, the change is propagated into the model. This introduces a refreshing bug where model's description page is not refreshed properly. I think rather than trying to force a workaround here, we should just wait for the model page refactor/restructure that we plan to solve this, and other issues.

Testing

Open up a model

  • Go to the model tab
  • Change a parameter's value for Default config
  • Refresh the page, note that a) The change is persisting, and b) the Description page reflects the same change

@mwdchang mwdchang marked this pull request as ready for review August 18, 2023 17:12
@mwdchang mwdchang requested a review from YohannParis as a code owner August 18, 2023 17:12
@mwdchang mwdchang requested a review from shawnyama August 18, 2023 17:12
@mwdchang mwdchang merged commit f475c84 into main Aug 21, 2023
@mwdchang mwdchang deleted the edit-default-config branch August 21, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants