Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue where duplicate and blank publication appears when adding for the first time #1749

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: issue where duplicate and blank publication appears when adding for the first time #1749

merged 1 commit into from
Aug 22, 2023

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Aug 22, 2023 •
edited
Loading

Description

  • Fixed an issue where added publications to a project would cause duplicate an empty publication and a blank publication
  • removed line of code which added the publications to the project locally but this is no necessary since the project page is reloaded when we navigate to the page
Screen.Recording.2023-08-22.at.12.56.28.PM.mov

@blanchco blanchco linked an issue Aug 22, 2023 that may be closed by this pull request
[BUG]: Adding a document to a project from Explorer creates a double and a blank in the resources panel #1671
Closed
@blanchco blanchco marked this pull request as ready for review August 22, 2023 16:57
YohannParis
YohannParis approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's comic!

@blanchco blanchco merged commit 5fdb5cb into main Aug 22, 2023
@blanchco blanchco deleted the fix-duplicate-and-blank-publications branch August 22, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Adding a document to a project from Explorer creates a double and a blank in the resources panel
2 participants
@blanchco @YohannParis