Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor services/project call out of components using composables #1785

Merged
merged 62 commits into from
Sep 22, 2023
Merged

chore: refactor services/project call out of components using composables #1785

merged 62 commits into from
Sep 22, 2023

Conversation

echl
Copy link
Contributor

@echl echl commented Aug 28, 2023

Description

  • Use composable to pass project object to components
  • Remove use of resources store to get project data

Resolves #1734

@echl echl changed the title chore: refactor services/project call out of components chore: refactor services/project call out of components - composables Aug 28, 2023
@echl echl changed the title chore: refactor services/project call out of components - composables chore: refactor services/project call out of components using composables Aug 28, 2023
echl added 20 commits September 7, 2023 10:06
@echl
Merge branch 'main' into refactor-project-service-calls
cc79698
@echl
refactor tera-selected-document-pane-
8836e42
@echl
refactor tera-navbar, tera-project-card
4cfa7b8
@echl
refactor Home
c2fa8fa
@echl
Merge branch 'main' into refactor-project-service-calls
1afd13a
@echl
refactor selected resources
2f305f9
@echl
refactor tera-project-overview; tera-import-github-file; code.ts
a50bbd5
@echl
undo application.properties commit
74176fc
@echl
refactor tera-project-overview; tera-import-github-file; artifact.ts
805beee
@echl
refactor tera-project-overview; tera-import-github-file; dataset.ts
26a9e0d
@echl
Merge branch 'main' into refactor-project-service-calls
1426394
@echl
refactor dataset.ts, model.ts, tera-model-modal
a07186d
@echl
refactor tera-code
1cf97aa
@echl
refactor tera-dataset, dataset.ts
a999c21
@echl
refactor tera-project-page, tera-model
983e583
@echl
remove use of resource store for getting project or asset data
c81a373
@echl
code-editor
7459194
@echl
Merge branch 'main' into refactor-project-service-calls
edf352d
@echl
Merge branch 'main' into refactor-project-service-calls
80becda
@echl
undo application properties change
f046548
@echl echl marked this pull request as ready for review September 12, 2023 19:20
@echl echl assigned echl and YohannParis and unassigned echl Sep 12, 2023
echl added 18 commits September 20, 2023 13:32
@echl
remove unneeded function arg
2956c05
@echl
remove unneeded prop
3bf705f
@echl
extract things to functions
45c1290
@echl
shouldn't have removed project prop from this component
4aa0254
@echl
use useProjects() directly instead of destructuring
2902a9e
@echl
fix addasset arg order; refresh project only if added asset is added …
8fc889c 
…to active project
@echl
refresh active project only if deleted asset from active project
012d53a
@echl
fix undefined error
154c673
@echl
type fix
e59ded7
@echl
fix annoying warning
8df982b
@echl
fix loading state issue; typing
f3d5933
@echl
fix a condition; adjust timeout
c9e2839
@echl
use useProjects() directly instead of destructuring
aeaeefa
@echl
useProject updates
3f7e689
@echl
use useProjects() directly instead of destructuring
78fe226
@echl
dataset service changes
b3fe6ef
@echl
Merge branch 'main' into refactor-project-service-calls
cf8c3fb
@echl
consolidate project type; fix home loading state
3739ed3
@echl echl merged commit d375c5d into main Sep 22, 2023
@echl echl deleted the refactor-project-service-calls branch September 22, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

Assignees

@YohannParis YohannParis

@mwdchang mwdchang

@Tom-Szendrey Tom-Szendrey

@shawnyama shawnyama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor services/project call out of components into tera-project
5 participants
@echl @YohannParis @mwdchang @Tom-Szendrey @shawnyama