Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: renaming extraction-service to knowledge-middleware #1803

Merged
merged 16 commits into from
Aug 31, 2023
Merged

task: renaming extraction-service to knowledge-middleware #1803

merged 16 commits into from
Aug 31, 2023

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Aug 30, 2023 •
edited
Loading

Description

  • Change the extraction-service call to knowledge-middleware

@YohannParis YohannParis mentioned this pull request Aug 30, 2023
Merged
@YohannParis YohannParis requested a review from mwdchang as a code owner August 30, 2023 19:33
@YohannParis YohannParis marked this pull request as draft August 30, 2023 19:35
@YohannParis YohannParis changed the base branch from main to yohannparis/change-url-for-knowledge-middleware August 30, 2023 19:36
@YohannParis YohannParis requested review from echl and shawnyama August 30, 2023 19:50
@YohannParis YohannParis marked this pull request as ready for review August 30, 2023 19:50
@YohannParis YohannParis changed the base branch from yohannparis/change-url-for-knowledge-middleware to main August 30, 2023 19:51
@shawnyama
Copy link
Contributor

shawnyama commented Aug 30, 2023 •
edited
Loading

Why is the application.properties change reverted? never mind I see the other pr

@YohannParis YohannParis merged commit b832cad into main Aug 31, 2023
@YohannParis YohannParis deleted the yohannparis/renaming-extraction-to-knowledge branch August 31, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@shawnyama shawnyama shawnyama approved these changes

@mwdchang mwdchang mwdchang approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@echl echl Awaiting requested review from echl

Assignees

@Jami159 Jami159

@echl echl

@shawnyama shawnyama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YohannParis @shawnyama @mwdchang @dvince2 @dgauldie @Jami159 @echl