Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: floating windows example #1834

Merged
merged 26 commits into from
Sep 12, 2023
Merged

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Sep 8, 2023

Description

Added a method to load Workflow node on their own floating window instead of a split panel.

Clean up

  • Rename tera-simulation-worflow to tera-workflow as this is more than simulation now.
  • Made project an optional prop on some node wrapper: disable the Save as Dataset button if not provided.

Work

  • Made a util to display workflow-node into a unique floating window instead of a split panel.
  • New WorkflowNode route and page to display nodes on their own, not within a project.
  • This does not work on full-screen, it will open a new tab in most browser.

Video

Screen.Recording.2023-09-11.at.13.29.03.mov

@YohannParis YohannParis self-assigned this Sep 8, 2023
@YohannParis YohannParis marked this pull request as ready for review September 11, 2023 17:28
@YohannParis YohannParis requested a review from Jami159 September 11, 2023 17:33
@Tom-Szendrey
Copy link
Contributor

Tom-Szendrey commented Sep 11, 2023

I think there is an issue here due to the refreshing rate of our workflow.
Our workflow only saves periodically.
If i create a node and try to open it, I will then only see the opened node if I opened it after that workflow save has happened:

Screen.Recording.2023-09-11.at.2.18.10.PM.mov

@Tom-Szendrey
Copy link
Contributor

Tom-Szendrey commented Sep 11, 2023

There are some state communication/saving issues going on here:
This will prevent us from running a calibration that involves mapping for example

Screen.Recording.2023-09-11.at.2.20.52.PM.mov

@YohannParis
Copy link
Member Author

@Tom-Szendrey both points are correct, but out of the scope of this PR, this is mostly to show that it is possible to display those nodes on a floating window. The synchronisation and refresh rate of saving a workflow is two complete beast on their own.

@YohannParis YohannParis merged commit 95c1256 into main Sep 12, 2023
@YohannParis YohannParis deleted the yohannparis/pop-windows-example branch September 12, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants