Disable multiple inputs into same simulate box #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a decent number of list-processing logic in the simulate boxes. If indeed we don't need to accept multiple configurations anymore we might as well try to simplify them, as I recall they were rather quickly hacked together, so cleaning things up would make the code more manageable. |
This reverts commit 29e452d.
dvince2
reviewed
Oct 10, 2023
.../software/uncharted/terarium/hmiserver/proxies/simulationservice/SimulationServiceProxy.java
Outdated
Show resolved
Hide resolved
dvince2
reviewed
Oct 10, 2023
...are/uncharted/terarium/hmiserver/proxies/simulationservice/SimulationCiemssServiceProxy.java
Outdated
Show resolved
Hide resolved
dvince2
approved these changes
Oct 10, 2023
mwdchang
reviewed
Oct 10, 2023
packages/client/hmi-client/src/workflow/ops/simulate-julia/tera-simulate-node-julia.vue
Show resolved
Hide resolved
mwdchang
requested changes
Oct 10, 2023
There was a problem hiding this comment.
There are a few confusing points that should be addressed
- You removed the
v-for" context for the tera-simulate-chart, but you still have a:key` assignment, so what exactly do you want to do? - I think you might be mangling the
:run-resultsassignment in tera-simulate-chart, can you clarify what is been passed in? Seems like you are passing in the value but the chart is expecting an object-map?
|
How does "add-chart" work under this new logic? |
mwdchang
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1898 #1899