Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provenance to model to doc #1921

Merged
merged 25 commits into from
Oct 20, 2023
Merged

feat: provenance to model to doc #1921

merged 25 commits into from
Oct 20, 2023

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Oct 2, 2023

Description

  • A working-ish version of adding and reading provenance for model/dataset enrichments. Will need to do some updates when changes have been made to the data-service around provenance to add document assets. For now I used the EXTRACTED_FROM relation and PUBLICATION for the linking. I'm assuming a relation like ENRICHED_FROM and asset type DOCUMENT will be added in some time.
  • provenance linkage happens on profile-model and profile-dataset calls in the backend
  • added provenance service to FE
  • fixed up getRelatedArtifacts function to retrieve artifacts
Screen.Recording.2023-10-13.at.5.39.22.PM.mov

Resolves #(issue)

@blanchco blanchco linked an issue Oct 2, 2023 that may be closed by this pull request
@blanchco blanchco self-assigned this Oct 5, 2023
@blanchco
Copy link
Contributor Author

blanchco commented Oct 18, 2023

@YohannParis Unsure if we should merge this now or after the provenance updates...
There are some changes needed in provenance like an updated relation type such as ENRICHED_FROM and the DOCUMENT asset type. The provenance linking works albeit the relation and asset type being incorrect. We would simply need to make a few changes in a separate issue update it once the provenance work is updated if we wanted to merge this now.

Also some food for thought, the actual creation of the provenance link might be better done on the knowledge-middleware side for the enrichment jobs. Right now it is adding the provenance link whether or not the job fails or succeeds on the profile-dataset or profile-model calls in the hmi-server. If we were to add the linking on the hmi-client after the enrichment is done there may be cases where the user exits the application in the middle of enrichment and the provenance creation would not happen despite the job being kicked off. So creation of the provenance link on the hmi-server or hmi-client would not be 100%.

cc. @brandomr

@blanchco blanchco marked this pull request as ready for review October 18, 2023 20:10
…-documents.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
@blanchco blanchco merged commit cf5bd9b into main Oct 20, 2023
6 checks passed
@blanchco blanchco deleted the feat-provenance-model-to-doc branch October 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add provenance after model/dataset enrichment
3 participants