Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor fix #1931

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: minor fix #1931

merged 1 commit into from
Oct 3, 2023

Conversation

Tom-Szendrey
Copy link
Contributor

Description

hmiserver was not able to use currentUserService in this file as it was not set up (was just null)

@Tom-Szendrey Tom-Szendrey requested a review from dgauldie as a code owner October 3, 2023 13:18
@Tom-Szendrey Tom-Szendrey requested a review from dvince2 as a code owner October 3, 2023 13:18
@Tom-Szendrey Tom-Szendrey changed the title minor fix fix: minor fix Oct 3, 2023
dvince2
dvince2 reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dvince2
Copy link
Collaborator

dvince2 commented Oct 3, 2023

@dgauldie or @YohannParis can you force merge this?

@YohannParis YohannParis merged commit c54ac1f into main Oct 3, 2023
3 of 4 checks passed
@YohannParis YohannParis deleted the projectResource-minor branch October 3, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 left review comments

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

Assignees

@bigglesandginger bigglesandginger

@dvince2 dvince2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tom-Szendrey @dvince2 @YohannParis @bigglesandginger