Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: add better intellij support for local devlopment #1937

Merged
merged 12 commits into from
Oct 3, 2023
Merged

task: add better intellij support for local devlopment #1937

merged 12 commits into from
Oct 3, 2023

Conversation

YohannParis
Copy link
Member

Description

  • Remove the old packages/services
  • Added a start-server-intellij function to ./hmiServerDev.sh to use with Intellij
  • Refactor ./hmiServerDev.sh

@YohannParis YohannParis marked this pull request as ready for review October 3, 2023 17:13
dvince2
dvince2 reviewed Oct 3, 2023
View reviewed changes
hmiServerDev.sh Outdated Show resolved Hide resolved
@dvince2 dvince2 self-requested a review October 3, 2023 18:08
dvince2
dvince2 requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the java files deleted from the old quarkus server? They're the logging system which hasn't been migratrated yet and we don't want to lose the history on those when they're migrated

mwdchang
mwdchang reviewed Oct 3, 2023
View reviewed changes
hmiServerDev.sh Outdated Show resolved Hide resolved
@YohannParis YohannParis requested a review from dvince2 October 3, 2023 18:56
@YohannParis YohannParis merged commit a1423db into main Oct 3, 2023
@YohannParis YohannParis deleted the yohannparis/add-info-into-readme branch October 3, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@dvince2 dvince2 dvince2 approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@pascaleproulx pascaleproulx Awaiting requested review from pascaleproulx pascaleproulx is a code owner

@chris-dickson chris-dickson Awaiting requested review from chris-dickson

Assignees

@dgauldie dgauldie

@dvince2 dvince2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YohannParis @mwdchang @dvince2 @dgauldie