chore: project assets for text files are now documents (not artifacts) #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
requested review from
dgauldie,
dvince2,
YohannParis and
mwdchang
as code owners
|
Setting as draft because i still need to test, im not familiar with the |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final HttpResponse response = httpclient.execute(httpGet); | ||
| final String textFileAsString = IOUtils.toString(response.getEntity().getContent(), StandardCharsets.UTF_8); | ||
|
|
||
| return ResponseEntity.ok(textFileAsString); |
Check warning
Code scanning / CodeQL
Cross-site scripting
YohannParis
reviewed
Oct 10, 2023
packages/client/hmi-client/src/components/documents/tera-document-asset.vue
Outdated
Show resolved
Hide resolved
|
If we're making .txt's documents, we should also move .md's in as well as I know that Pascale wants to be able to use README.md's to enrich. |
|
…S/1987-task-change-txt-type-to-document
YohannParis
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Txt is now a document not an artifact:
Utilizing the code editor for txt files