Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify overview page - make banner fit in the actual header #2001

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 11, 2023

Description

Note the background fills the bottom with white. Before the banner background was used as the main background. The banner background is moved to the header of tera-asset.vue when Overview is chosen.

image

@shawnyama shawnyama marked this pull request as ready for review October 11, 2023 18:30
@shawnyama shawnyama requested a review from echl October 11, 2023 18:31
@mwdchang
Copy link
Member

Not sure if it is possible or how difficult it is, can we leverage pageType/assetType instead of an isOverView predicate? It makes tera-asset a little more idiomatic in terms of reading.

@YohannParis
Copy link
Member

I don't understand the need to do this task?

@shawnyama
Copy link
Contributor Author

I don't understand the need to do this task?

Overview page wasn't fitting the space properly. Just got annoyed looking at it while removing tabs.

@shawnyama shawnyama merged commit f8478f7 into main Oct 11, 2023
5 checks passed
@shawnyama shawnyama deleted the overview-adjust branch October 11, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants