Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: equation to model and default configurations #2006

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

blanchco
Copy link
Contributor

Description

Fixes for equations to amr:

  • when saving equations to amr, the editing state will close.

Fixes for default config:
Before:

  • when creating a model and there were no default configurations, an empty default config would be made and never updated.
  • specifically when called equations_to_amr, the knowledge-middleware would create a model configuration that was no the 'Default config', we then ended up with an empty 'Default Config' and a new model configuration from knowledge-middleware.

After:

  • an empty model config will not be made automatically when a new model is create (there is an empty check for states and transitions)
  • when the model is updated and there are no configurations a default config will be created if it does no already exist.

This PR will need a follow-up PR for it to fully be completed. In the knowledge-middleware the model configuration through equations_to_amr will need to be called 'Default config'.

Screen.Recording.2023-10-11.at.4.48.28.PM.mov

@blanchco blanchco self-assigned this Oct 11, 2023
@blanchco blanchco linked an issue Oct 11, 2023 that may be closed by this pull request
@blanchco blanchco merged commit d6abf88 into main Oct 12, 2023
5 checks passed
@blanchco blanchco deleted the equation-to-model-fixes branch October 12, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Model from equations does not end properly
2 participants