fix: equation to model and default configurations #2006
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for equations to amr:
Fixes for default config:
Before:
equations_to_amr
, the knowledge-middleware would create a model configuration that was no the 'Default config', we then ended up with an empty 'Default Config' and a new model configuration from knowledge-middleware.After:
This PR will need a follow-up PR for it to fully be completed. In the knowledge-middleware the model configuration through
equations_to_amr
will need to be called 'Default config'.Screen.Recording.2023-10-11.at.4.48.28.PM.mov