Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: new button group style and leverage SelectButton component #2019

Merged
merged 12 commits into from
Oct 17, 2023
Merged

style: new button group style and leverage SelectButton component #2019

merged 12 commits into from
Oct 17, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 13, 2023 •
edited
Loading

Description

Following new design for button groups - also made use of SelectButton component

Using :modelValue + @change combo to update selection. v-model by itself enables deselection if you reselect what you have already selected.

Screen.Recording.2023-10-16.at.3.25.26.PM.mov

@shawnyama shawnyama linked an issue Oct 13, 2023 that may be closed by this pull request
[FEAT]: UX: Button group - design revision #1965
Closed
@shawnyama shawnyama changed the title feat: new button group style and leverage SelectButton component style: new button group style and leverage SelectButton component Oct 13, 2023
@shawnyama shawnyama marked this pull request as ready for review October 16, 2023 21:32
YohannParis
YohannParis approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🎉

P.S. if you want to have fun, maybe we could make the active white background a div, that slide to the selected element. With a slick ease-in-out animation it would look dope.

@shawnyama shawnyama merged commit efd369e into main Oct 17, 2023
5 checks passed
@shawnyama shawnyama deleted the new-btn-group branch October 17, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: UX: Button group - design revision
2 participants
@shawnyama @YohannParis