Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: update modal designs and create secondary button rule #2067

Merged
merged 6 commits into from
Oct 20, 2023
Merged

style: update modal designs and create secondary button rule #2067

merged 6 commits into from
Oct 20, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 20, 2023 •
edited
Loading

Description

  • Fullscreen modal scrolls with fixed header
  • Made width/border adjustments to normal modal as well as a proper secondary button that Neil discussed with me
Screen.Recording.2023-10-20.at.12.08.02.PM.mov

@shawnyama shawnyama linked an issue Oct 20, 2023 that may be closed by this pull request
[TASK]: UX Design: Adjustments to modals #2017
Closed
@shawnyama shawnyama marked this pull request as ready for review October 20, 2023 18:11
@shawnyama shawnyama requested a review from blanchco October 20, 2023 18:13
YohannParis
YohannParis approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉
I Love a good cleaning.

@shawnyama shawnyama merged commit 8550420 into main Oct 20, 2023
5 checks passed
@shawnyama shawnyama deleted the modal-css-update branch October 20, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: UX Design: Adjustments to modals
2 participants
@shawnyama @YohannParis