Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl tera-text-editor #2072

Merged
merged 10 commits into from
Oct 25, 2023
Merged

feat: impl tera-text-editor #2072

merged 10 commits into from
Oct 25, 2023

Conversation

echl
Copy link
Contributor

@echl echl commented Oct 20, 2023

  • Implement barebones tera-text-editor component to replace remaining uses of code-editor
  • Contains pdf viewer for pdf files and rich text editor for text files
  • No ability to save edits to text files yet
Screen.Recording.2023-10-20.at.5.34.01.PM.mov

Resolves #1996

@mwdchang
Copy link
Member

@echl can you provide a few brief descriptions describing what the PR is trying to accomplish, and how to go about testing it? The issue you are pointing to isn't very helpful in terms of understanding the context.

@echl
Copy link
Contributor Author

echl commented Oct 20, 2023

@echl can you provide a few brief descriptions describing what the PR is trying to accomplish, and how to go about testing it? The issue you are pointing to isn't very helpful in terms of understanding the context.

Yes, will do when pr is finalized :)

@echl echl marked this pull request as ready for review October 20, 2023 21:35
@YohannParis YohannParis merged commit 5edaec3 into main Oct 25, 2023
5 checks passed
@YohannParis YohannParis deleted the 1996-text-editor branch October 25, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Document Text Viewer should be prettier and more functional
3 participants