Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code to model works with dynamics #2084

Merged
merged 12 commits into from
Oct 25, 2023
Merged

feat: code to model works with dynamics #2084

merged 12 commits into from
Oct 25, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 23, 2023

Description

Code to model works with dynamics:
I switch files back and forth after I create my dynamics just to show the code highlight is maintained

Screen.Recording.2023-10-24.at.3.47.04.PM.mov

If dynamics aren't specified it doesn't work...

Screen.Recording.2023-10-24.at.3.54.43.PM.mov

@shawnyama shawnyama marked this pull request as ready for review October 23, 2023 19:22
@shawnyama shawnyama marked this pull request as draft October 23, 2023 19:23
@shawnyama shawnyama linked an issue Oct 24, 2023 that may be closed by this pull request
@shawnyama shawnyama changed the title feat: save dynamic part of a code file feat: save dynamics from a code file Oct 24, 2023
@shawnyama shawnyama changed the title feat: save dynamics from a code file feat: model to code works with dynamics Oct 24, 2023
@shawnyama shawnyama marked this pull request as ready for review October 24, 2023 19:51
@shawnyama shawnyama changed the title feat: model to code works with dynamics feat: code to model works with dynamics Oct 24, 2023
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's an excellent second pass

@shawnyama shawnyama merged commit 4a809b2 into main Oct 25, 2023
6 checks passed
@shawnyama shawnyama deleted the save-dynamics branch October 25, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare code-to-model in code editor
3 participants