-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: code to model works with dynamics #2084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnyama
requested review from
dgauldie,
dvince2,
YohannParis and
mwdchang
as code owners
October 23, 2023 19:22
shawnyama
changed the title
feat: save dynamic part of a code file
feat: save dynamics from a code file
Oct 24, 2023
shawnyama
changed the title
feat: save dynamics from a code file
feat: model to code works with dynamics
Oct 24, 2023
shawnyama
changed the title
feat: model to code works with dynamics
feat: code to model works with dynamics
Oct 24, 2023
mwdchang
reviewed
Oct 25, 2023
YohannParis
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that's an excellent second pass
...server/src/main/java/software/uncharted/terarium/hmiserver/models/dataservice/code/Code.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code to model works with dynamics:
I switch files back and forth after I create my dynamics just to show the code highlight is maintained
Screen.Recording.2023-10-24.at.3.47.04.PM.mov
If dynamics aren't specified it doesn't work...
Screen.Recording.2023-10-24.at.3.54.43.PM.mov