Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edit model configs #2092

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: edit model configs #2092

merged 1 commit into from
Oct 24, 2023

Conversation

blanchco
Copy link
Contributor

Description

  • fixed an issue where you couldn't edit the first model config
  • close modal when updated model config

@blanchco blanchco requested a review from YohannParis as a code owner October 24, 2023 16:10
@blanchco blanchco self-assigned this Oct 24, 2023
@blanchco blanchco requested a review from mwdchang as a code owner October 24, 2023 16:10
@blanchco blanchco requested a review from shawnyama October 24, 2023 16:10
@blanchco blanchco linked an issue Oct 24, 2023 that may be closed by this pull request
[BUG]: Not able to open some model configuration variables and model configuration modal does not close when saved #2090
Closed
@blanchco blanchco requested a review from Jami159 October 24, 2023 19:58
Jami159
Jami159 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Jami159 Jami159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blanchco blanchco merged commit 0b52641 into main Oct 24, 2023
5 checks passed
@blanchco blanchco deleted the fix-edit-model-configs branch October 24, 2023 20:01
YohannParis
YohannParis reviewed Oct 25, 2023
View reviewed changes
packages/client/hmi-client/src/components/model/petrinet/tera-model-configurations.vue
openValueConfig && modalAttributes.stratifiedMatrixType && modalAttributes.odeObjIndex
openValueConfig &&
modalAttributes.stratifiedMatrixType &&
isNumber(modalAttributes.odeObjIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of lodash!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis left review comments

@Jami159 Jami159 Jami159 approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@blanchco @YohannParis @Jami159