Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: spinner for documents #2101

Merged
merged 2 commits into from
Oct 27, 2023
Merged

task: spinner for documents #2101

merged 2 commits into from
Oct 27, 2023

Conversation

blanchco
Copy link
Contributor

Description

  • Adding a spinner when navigating to a document, this endpoint does take a while to show - so giving a sense of progress here.
  • I figure it wouldn't hurt to add a simple spinner component here and we can define its size.
  • Added a snippet of text for the scenario when pdf-extractions haven't completed. This can probably be refactored when we work on this and can listen to these async job properly
Screen.Recording.2023-10-26.at.4.56.07.PM.mov

@blanchco blanchco self-assigned this Oct 26, 2023
@blanchco blanchco linked an issue Oct 26, 2023 that may be closed by this pull request
[TASK]: Add spinner while document extractions are in progress #2096
Closed
YohannParis
YohannParis approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, but this could be added to Tera-Asset as a loading prop!

@blanchco
Copy link
Contributor Author

Neat, but this could be added to Tera-Asset as a loading prop!

good idea, i was trying to figure out a way to do this better...I might look at adding this to every asset type tomorrow morning

@blanchco
Copy link
Contributor Author

@YohannParis loading has been added for all assets on their initial load, leveraging the tera-asset.

@blanchco blanchco merged commit 196f354 into main Oct 27, 2023
5 checks passed
@blanchco blanchco deleted the task-spinner-for-documents branch October 27, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Add spinner while document extractions are in progress
2 participants
@blanchco @YohannParis