Task[hmi-server]: reimplement ssemq on hmi server #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ssemq-on-hmi-server
…-ssemq-on-hmi-server
…-ssemq-on-hmi-server
…-ssemq-on-hmi-server
…-ssemq-on-hmi-server
Hopefully the second last commit. this is working but needs a little cleanup before merging.
…-ssemq-on-hmi-server
This reverts commit 5710176.
dvince2
requested review from
dgauldie,
YohannParis,
mwdchang and
chris-dickson
as code owners
mwdchang
approved these changes
Nov 3, 2023
YohannParis
requested changes
Nov 3, 2023
| @@ -33,6 +33,7 @@ | |||
| "@lumino/commands": "2.1.3", | |||
| "@lumino/coreutils": "2.1.2", | |||
| "@lumino/widgets": "2.1.0", | |||
| "@microsoft/fetch-event-source": "^2.0.1", | |||
There was a problem hiding this comment.
Please use yarn add --exact @microsoft/fetch-event-source to pin the version number.
There was a problem hiding this comment.
Looks good, but this should go under /api folder as it is a utils and not a service per se.
Comment on lines
-238
to
+246
| const handleIntermediateResult = (message: string) => { | ||
| /* const handleIntermediateResult = (message: string) => { | ||
| const parsedMessage = JSON.parse(message); | ||
| console.log(parsedMessage); | ||
| }; | ||
| }; */ |
| import TeraSimulateChart from '@/workflow/tera-simulate-chart.vue'; | ||
| import TeraProgressBar from '@/workflow/tera-progress-bar.vue'; | ||
| import { getTimespan } from '@/workflow/util'; | ||
| import { logger } from '@/utils/logger'; | ||
| import { subscribe, unsubscribe } from '@/services/ClientEventService'; |
There was a problem hiding this comment.
Suggested change
| import { subscribe, unsubscribe } from '@/services/ClientEventService'; | |
| import * as ClientEventService from '@/services/ClientEventService'; |
Better to then call ClientEventService.subscribe()
| @@ -42,6 +42,11 @@ public class Config { | |||
| */ | |||
| ClientConfig clientConfig; | |||
|
|
|||
| /** | |||
| * If queues should be declared durable. IF running Rabbit inside docker, this should be false | |||
There was a problem hiding this comment.
Suggested change
| * If queues should be declared durable. IF running Rabbit inside docker, this should be false | |
| * If queues should be declared durable. | |
| * If running Rabbit inside docker, this should be false. |
| @@ -83,3 +84,9 @@ tgpt.ws.url=wss://app.staging.terarium.ai/beaker_ws/ | |||
| ######################################################################################################################## | |||
| spicedb.launchmode=TLS | |||
| spicedb.target=spicedb.staging.terarium.ai:443 | |||
|
|
|||
| # RabbitMQ exchange | |||
There was a problem hiding this comment.
Suggested change
| # RabbitMQ exchange | |
| ######################################################################################################################## | |
| # RabbitMQ exchange | |
| ######################################################################################################################## |
Comment on lines
+49
to
+51
| if (handlers) { | ||
| handlers.forEach((handler) => handler(data)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (handlers) { | |
| handlers.forEach((handler) => handler(data)); | |
| } | |
| if (handlers) { | |
| handlers.forEach((handler) => handler(data)); | |
| } else { | |
| logger.info(`Message ${data.type} has no handler available`); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2004