Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2165 finishing sse feedback #2173

Merged
merged 2 commits into from
Nov 7, 2023
Merged

2165 finishing sse feedback #2173

merged 2 commits into from
Nov 7, 2023

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Nov 7, 2023

Description

  • Changing sse for sciml calibrate to not broadcast to everyone, but instead, only broadcast to specific users.
  • Created a POJO for the intermediate results for sciml calibrate to make it a bit easier to manage queues on the back end (And the front end gets a nice object too!)
  • This will have to be replicated to pyciemss when we get there.

Because of the stabiltiy issues on the staging sciml, @Jami159 has helped me debug and confirm this is working as expected.

Resolves #2165

@dvince2
SSE per user simulation updates
1828b07 
Update only the users who are watching this queue
@dvince2
SSE per user simulation updates
39e5f77 
Update only the users who are watching this queue
@dvince2 dvince2 requested a review from Jami159 November 7, 2023 14:53
@dvince2 dvince2 linked an issue Nov 7, 2023 that may be closed by this pull request
Finishing SSE feedback #2165
Closed
@dvince2 dvince2 merged commit e47b2c3 into main Nov 7, 2023
6 checks passed
@dvince2 dvince2 deleted the 2165-finishing-sse-feedback branch November 7, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jami159 Jami159 Jami159 approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finishing SSE feedback
2 participants
@dvince2 @Jami159