Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit/create project modal #2174

Merged
merged 13 commits into from
Nov 8, 2023
Merged

feat: edit/create project modal #2174

merged 13 commits into from
Nov 8, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Nov 7, 2023

Description

  • Shared modal for creating and editing project configuration
  • UI for domain and image select is done but is disabled until we have backend support for those
  • Remove usage modal class where tera-modal component is used
Screen.Recording.2023-11-07.at.4.27.38.PM.mov

@shawnyama shawnyama marked this pull request as ready for review November 7, 2023 21:29
@shawnyama shawnyama requested a review from blanchco November 7, 2023 21:32
@YohannParis
Copy link
Member

Based on the video, does this PR also closes #2159 ?

@shawnyama shawnyama marked this pull request as draft November 7, 2023 21:44
@shawnyama
Copy link
Contributor Author

Based on the video, does this PR also closes #2159 ?

Good catch - I meant to do that but the dialog boxes for those only appear if you're on the home page - will fix that.

@shawnyama shawnyama marked this pull request as ready for review November 7, 2023 22:28
@shawnyama
Copy link
Contributor Author

shawnyama commented Nov 7, 2023

@YohannParis I just migrated the share and remove modals properly. I am not leveraging the project-menu.ts composable though. If we were to use that I think we would have to put the modals in App.vue instead. Then from tera-project-menu.vue you'd trigger the states of the modals using the composable. Not sure what we want to go for.

…nu.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
@YohannParis
Copy link
Member

@YohannParis I just migrated the share and remove modals properly. I am not leveraging the project-menu.ts composable though. If we were to use that I think we would have to put the modals in App.vue instead. Then from tera-project-menu.vue you'd trigger the states of the modals using the composable. Not sure what we want to go for.

I think that how this should be behave honestly. Let me know how hard it would be to do so.

@shawnyama shawnyama marked this pull request as draft November 8, 2023 16:37
@shawnyama shawnyama marked this pull request as ready for review November 8, 2023 18:40
@shawnyama shawnyama requested a review from YohannParis November 8, 2023 18:41
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's much tidier

@shawnyama shawnyama merged commit 88e3c08 into main Nov 8, 2023
5 checks passed
@shawnyama shawnyama deleted the new-create-proj branch November 8, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: New create/edit project modal Copy share project UI to the overview page
2 participants