SSE and mq improvements #2178
Merged
SSE and mq improvements #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing the silencing of some errors. these errors mean something! * Reverting change to ClientEventService.ts which resulted in `init()` being spammed every second * Queues should not be exclusive. This will require us to blow away queues on rabbitmq after this merge * Queues are not durable. * Maps of connections and users should be concurrent safe.
dvince2
requested review from
dgauldie,
YohannParis and
mwdchang
as code owners
YohannParis
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init()being spammed every secondDescription
Resolves #(issue)