Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect to overview page if you removed an asset that's currently opened #2254

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Nov 16, 2023

Description

If you remove an asset that is currently opened it will now redirect to the overview page instead of staying at the deleted asset.

Screen.Recording.2023-11-16.at.3.35.37.PM.mov

@shawnyama shawnyama changed the title fix: redirect to overview page if you're removing an opened asset fix: redirect to overview page if you're removed an opened asset Nov 16, 2023
@shawnyama shawnyama marked this pull request as ready for review November 16, 2023 20:43
@shawnyama shawnyama changed the title fix: redirect to overview page if you're removed an opened asset fix: redirect to overview page if you removed an asset that's currently opened Nov 16, 2023
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@mwdchang mwdchang merged commit 685e34a into main Nov 17, 2023
5 checks passed
@mwdchang mwdchang deleted the redirect-on-asset-removal branch November 17, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants