Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: loader issues #2263

Merged
merged 1 commit into from
Nov 17, 2023
Merged

bug: loader issues #2263

merged 1 commit into from
Nov 17, 2023

Conversation

blanchco
Copy link
Contributor

Description

Fixed an issue related to the asset loader where it would be slow to show up or not even show at all. This was because the tera-asset was in a v-if condition which wouldn't even show the tera-asset component that contains the loader.

BEFORE

Screen.Recording.2023-11-17.at.10.43.35.AM.mov

AFTER

Screen.Recording.2023-11-17.at.10.42.18.AM.mov

@blanchco blanchco self-assigned this Nov 17, 2023
@blanchco blanchco linked an issue Nov 17, 2023 that may be closed by this pull request
@blanchco blanchco requested a review from shawnyama November 17, 2023 15:54
Copy link
Contributor

@shawnyama shawnyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@shawnyama shawnyama merged commit 57f2d75 into main Nov 17, 2023
5 checks passed
@shawnyama shawnyama deleted the bug-loader-issues branch November 17, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Loader does not work for Document asset
2 participants